Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for sameColumns in ColumnMetrics breaks Selectable Cell example #15

Open
malonecj opened this issue Aug 12, 2014 · 0 comments
Open

Comments

@malonecj
Copy link

In commit ba519b8 a check was added to prevent state from being reset if nextProps columns do not differ from previous ones.

This breaks the example listed here http://prometheusresearch.github.io/react-grid/examples/selectable-cells.html once you use the keyboard navigation to scroll past the current viewport height.

I guess this check should remain here as columnMetrics should be unaware of scroll height. Potentially, set the scrollTop in GridScrollMixin when this occurs so we can re-render grid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant