Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cgroup paths containing colons #354

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Jan 26, 2021

This change adds support for cgroup paths containing colons in the /procs//cgroup file.

This is prompted by the following:

  • The spec specifies that the three fields are separated by colons and does not forbid them in the path
  • Tools such as containerd joins path components with colons when using systemd as a cgroup provider

This closes #353

Signed-off-by: Evan Lezar <evanlezar@gmail.com>
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 9ad681c into prometheus:master Feb 3, 2021
@elezar elezar deleted the gh353-colons-in-cgroup-path branch February 3, 2021 09:54
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
Signed-off-by: Evan Lezar <evanlezar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cgroup paths containing ":" are not supported
3 participants