Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

procfs: implement parsing of NetSockstat{,6} #237

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Conversation

mdlayher
Copy link
Contributor

@mdlayher mdlayher commented Nov 23, 2019

Signed-off-by: Matt Layher mdlayher@gmail.com

Fixes #229.

@mdlayher mdlayher force-pushed the mdl-sockstat branch 3 times, most recently from aca0caf to 437b9ca Compare November 23, 2019 05:21
@mdlayher mdlayher changed the title procfs: start implementing NetSockstat{,6} procfs: implement parsing of NetSockstat{,6} Nov 23, 2019
@mdlayher mdlayher marked this pull request as ready for review November 23, 2019 05:22
@SuperQ
Copy link
Member

SuperQ commented Nov 24, 2019

Hrmm, there's no update to the end to end test.

@mdlayher
Copy link
Contributor Author

We don't have those in procfs right?

@mdlayher
Copy link
Contributor Author

Thoughts on the implementation here?

@SuperQ
Copy link
Member

SuperQ commented Nov 25, 2019

Sorry, I was confused, thought I was looking at the node_exporter repo. 🤦

net_sockstat.go Outdated Show resolved Hide resolved
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, otherwise LGTM

Signed-off-by: Matt Layher <mdlayher@gmail.com>
@mdlayher mdlayher merged commit 4711af0 into master Nov 25, 2019
@mdlayher mdlayher deleted the mdl-sockstat branch November 25, 2019 17:27
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
procfs: implement parsing of NetSockstat{,6}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parsing of sockstat
2 participants