Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slabinfo: Add filters for slab name. #3041

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

middaywords
Copy link
Contributor

@middaywords middaywords commented Jun 6, 2024

Add filter flags to the slab collector to allow reduced cardinality.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this to the filter list in the README.md.

README.md Outdated Show resolved Hide resolved
@SuperQ SuperQ changed the title slab-collector: add filter for slab name. slab: Add filters for slab name. Jun 6, 2024
Signed-off-by: Kangjie Xu <kanxu@ebay.com>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@SuperQ SuperQ changed the title slab: Add filters for slab name. slabinfo: Add filters for slab name. Jun 6, 2024
@SuperQ SuperQ merged commit dae4c87 into prometheus:master Jun 6, 2024
7 checks passed
v-zhuravlev pushed a commit to grafana/node_exporter that referenced this pull request Nov 1, 2024
Signed-off-by: Kangjie Xu <kanxu@ebay.com>
Co-authored-by: Kangjie Xu <kanxu@ebay.com>
Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants