sockstat: add support for RHE4 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm don't think we're going to support go 1.4.2 for Prometheus components (other than possibly the client library). |
|
thx for merging! btw... at least for node exporter, go 1.4.2 would be nice as getting any newer go to work on old platforms requires quite a bit of effort (remove all openat and other *at syscalls back to go 1.4.2 usage). |
Merged
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Synchronize Makefile.common from prometheus/prometheus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry for open a pull request for such a vintage OS, but the change is small and node exporter works reliable there after the patch (with go 1.4.2).
The only difference that caused a parsing error is a missing memory field in the UDP section of sockstat, i made the extraction of udp memory from sockstat optional with this patch.
ps.: just in case someone finds this post in need of a prometheus node-exporter for RHE4, one also needs a patched go 1.4.2