Add flag to ignore certain filesystem types (Copy of #217) #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duh, I wrote basically the same patch a couple of minutes ago before I noticed the existence of this pull request. I used the following pattern in my patch: Maybe you want to extend the default pattern? I would appreciate if this PR would be merged soon. Without it there are lots of useless time series on my systems esp because of |
|
👍 I think we should merge this and improve on the default list over time. I'd rather have a shorter/safer ignore list to start with. Individuals can change the list to suit their environment. |
| @@ -56,7 +63,8 @@ func init() { | |||
| // Filesystems stats. | |||
| func NewFilesystemCollector() (Collector, error) { | |||
| subsystem := "filesystem" | |||
| pattern := regexp.MustCompile(*ignoredMountPoints) | |||
| mountPointPattern := regexp.MustCompile(*ignoredMountPoints) | |||
| FSTypesPattern := regexp.MustCompile(*ignoredFSTypes) | |||
There was a problem hiding this comment.
Capitalized identifiers are exported. Please make this fsTypesPattern or filesystemTypesPattern.
Merged
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
procfs: ensure NetSockstat6 compatibility with os.IsNotExist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses at least some of the comments in #217.
It now compiles on Linux. I don't have any BSD lying around to test with.