-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document os support of each collector #200
Conversation
869fc0a
to
f47f3e9
Compare
interrupts | Exposes detailed interrupts statistics. | Linux OpenBSD | ||
ipvs | Exposes IPVS status from `/proc/net/ip_vs` and stats from `/proc/net/ip_vs_stats`. | Linux | ||
ksmd | Exposes kernel and system statistics from `/sys/kernel/mm/ksm`. | Linux | ||
lastlogin | Exposes the last time there was a login. | _any_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only works on one Linux distro, and I'm not sure which one it is. We really should delete this collector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It compiles on all OS though and can be used by any system having a conforming last
command. I'll put out another PR to delete lastlogin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It runs on fine on ubuntu, debian and arch though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't work for me on 12.04 when I tested it. It seems dependant on the exact output format of last
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It's still available on each operating system. The existence of this collector is outside of the scope of this PR.
@brian-brazil anything else? lastlogin is already in #101. |
👍 though I'd prefer commas between OS names. |
f47f3e9
to
e2163db
Compare
Document os support of each collector
Add all new collectors to the readme. Document which collector is available under which operating system.
This consolidates procfs collector compilation and only activates them under linux (I guess *bsd users didn't complain as they were disabled by default). Procfs collectors are possibly available under other operating systems as well (e.g. Solaris), see #199.
@brian-brazil @juliusv