Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runit exporter #2

Merged
merged 2 commits into from
Jul 29, 2013
Merged

Add runit exporter #2

merged 2 commits into from
Jul 29, 2013

Conversation

discordianfish
Copy link
Member

It exports one metric with a label for the service name and labels for the services status:

  {
     "metric" : {
        "value" : [
           {
              "value" : 1091,
              "labels" : {
                 "want" : "down",
                 "name" : "test",
                 "normally_up" : "yes",
                 "state" : "down"
              }
           },
           {
              "value" : 8,
              "labels" : {
                 "want" : "up",
                 "name" : "test",
                 "normally_up" : "yes",
                 "state" : "up"
              }
           }
        ],
        "type" : "gauge"
     },
     "docstring" : "node_exporter: status of runit service.",
     "baseLabels" : {
        "name" : "node_service_status"
     }
  }

But maybe we should have one metric per service? Not sure about that.

matttproud
matttproud reviewed Jul 25, 2013
View reviewed changes
exporter/runit_collector.go

var ()

type runitCollector struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cruft.

discordianfish added a commit that referenced this pull request Jul 29, 2013
@discordianfish
Merge pull request #2 from prometheus/feature/runit-exporter
4c2a270 
Add runit exporter
@discordianfish discordianfish merged commit 4c2a270 into master Jul 29, 2013
@discordianfish discordianfish deleted the feature/runit-exporter branch July 29, 2013 07:57
@cristi- cristi- mentioned this pull request May 29, 2017
Closed
@bazuchan bazuchan mentioned this pull request Mar 22, 2019
Closed
This was referenced Sep 2, 2019
Closed
Closed
arno01 added a commit to arno01/node_exporter that referenced this pull request Sep 2, 2019
@arno01
Fix apt.sh arch duplication (prometheus#1462)
13ccf92 
In some cases apt.sh could output duplicated arch values causing the
following error:

Aug 29 12:12:22 host123 prometheus-node-exporter[2235]: time="2019-08-29T12:12:22Z" level=error msg="error gathering metrics: [from Gatherer prometheus#2] collected metric \"apt_upgrades_pending\" { label:<name:\"arch\" value:\"Debian/Ubuntu\" > label:<name:\"origin\" value:\"PostgreSQLfor\" > gauge:<value:6 > } was collected before with the same name and label values\n" source="log.go:172"

Signed-off-by: Andrey Arapov <andrey.arapov@nixaid.com>
arno01 added a commit to arno01/node_exporter that referenced this pull request Sep 2, 2019
@arno01
Fix apt.sh arch duplication (prometheus#1462)
6695558 
In some cases apt.sh could output duplicated arch values causing the
following error:

Aug 29 12:12:22 host123 prometheus-node-exporter[2235]: time="2019-08-29T12:12:22Z" level=error msg="error gathering metrics: [from Gatherer prometheus#2] collected metric \"apt_upgrades_pending\" { label:<name:\"arch\" value:\"Debian/Ubuntu\" > label:<name:\"origin\" value:\"PostgreSQLfor\" > gauge:<value:6 > } was collected before with the same name and label values\n" source="log.go:172"

Signed-off-by: Andrey Arapov <andrey.arapov@nixaid.com>
@dm0610 dm0610 mentioned this pull request Aug 7, 2020
Closed
botranvan referenced this pull request in bizflycloud/node_exporter Jan 27, 2021
@botranvan
Merge pull request #2 from bizflycloud/add-gpu-exporter
26f2c28 
add gpu collector
bdrung added a commit to bdrung/node_exporter that referenced this pull request Oct 29, 2021
@bdrung
ethtool: Prevent duplicate metric names
865db3b 
Sanitizing the metric names can lead to duplicate metric names:

```
caller=level.go:63 level=error caller="error gathering metrics: [from Gatherer prometheus#2] collected metric \"node_ethtool_giant_hdr\" { label:<name:\"device\" value:\"ens192\" > untyped:<value:0" msg=" > } was collected before with the same name and label values"
```

Generate a map from the sanitized metric names to the metric names from
ethtool. In case of duplicate sanitized metric names drop both metrics,
because it is unknown which one to take.

Fixes: prometheus#2185
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
SuperQ pushed a commit that referenced this pull request Nov 15, 2021
@bdrung
ethtool: Prevent duplicate metric names (#2187)
d85cbaa 
Sanitizing the metric names can lead to duplicate metric names:

```
caller=level.go:63 level=error caller="error gathering metrics: [from Gatherer #2] collected metric \"node_ethtool_giant_hdr\" { label:<name:\"device\" value:\"ens192\" > untyped:<value:0" msg=" > } was collected before with the same name and label values"
```

Generate a map from the sanitized metric names to the metric names from
ethtool. In case of duplicate sanitized metric names drop both metrics,
because it is unknown which one to take.

Fixes: #2185
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
@zeronewb zeronewb mentioned this pull request Oct 21, 2022
Open
@frisbee23 frisbee23 mentioned this pull request Nov 15, 2022
Closed
@gnanasalten gnanasalten mentioned this pull request Sep 15, 2023
Open
@neilvvakil neilvvakil mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@discordianfish @matttproud @matttproud-soundcloud