Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (mdstat): resync=DELAYED if md arrays in checking and allocated on same physiclal units. #170

Closed
wants to merge 3 commits into from

Conversation

afefelov
Copy link
Contributor

mdstat collector fails on my RAID6 array I have few md arrays in checking state sitting on same physical units.

@brian-brazil
Copy link
Contributor

Can you update e2e-output.txt please so that the end-to-end test passes?

@@ -1,13 +1,13 @@
Personalities : [linear] [multipath] [raid0] [raid1] [raid6] [raid5] [raid4] [raid10]
md3 : active raid6 sda1[8] sdh1[7] sdg1[6] sdf1[5] sde1[11] sdd1[3] sdc1[10] sdb1[9]
5853468288 blocks super 1.2 level 6, 64k chunk, algorithm 2 [8/8] [UUUUUUUU]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your editor may have changed the fixture here, could you double-check whether these tabs are there in reality and if so, revert those changes?

@afefelov
Copy link
Contributor Author

@brian-brazil @matthiasr : fixed

@brian-brazil
Copy link
Contributor

I'm still seeing spaces being removed from the fixture, on my system there's 6 spaces in /proc/mdstat

@afefelov
Copy link
Contributor Author

@brian-brazil @matthiasr : fixed removed spaces, sorry for delay

@brian-brazil
Copy link
Contributor

Can you squash your commits?

pborzenkov and others added 3 commits December 16, 2015 19:40
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Enabled by default collectors are chosen for Linux, which supports all
of the implemented collectors. But for other OSes (OS X, for example)
this list is not suitable, because they lack most of those collectors.

Because of that, it is not possible to run node_exporter with default
options on such OSes. Fix this by filtering list of enabled by default
collectors based on their availability for current platform.

Closes prometheus#149

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
@afefelov
Copy link
Contributor Author

Rebased, thanks for help

@brian-brazil
Copy link
Contributor

I think you also need to do a rebase against master.

@afefelov
Copy link
Contributor Author

Sorry, it is not rebased against master now?

@brian-brazil
Copy link
Contributor

No, there's two other commits showing up in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants