Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gauges for allocated memory for queued UDP and TCP packages #1503

Merged
merged 10 commits into from
Mar 31, 2020
Merged

Add gauges for allocated memory for queued UDP and TCP packages #1503

merged 10 commits into from
Mar 31, 2020

Commits on Mar 13, 2020

  1. Two new states will be added to the tcpstat collector called rx_queue… 

    …d_bytes and tx_queued_bytes.

For UDP datagrams an additional collector 'udp_queues' can be used to expose the total lengths of the tx_queue and rx_queue.
@SuperQ and @discordianfish this changes gives us the option to check for overloaded UDP + TCP processing.
The names of the new TCP states and the UDP metric can be discussed.
The current reasons are just:

I don't want to add another collector for the same exposed file, so I just added the new states to the tcpstat collector.
I chose the name 'udp_queue' instead of 'udpstat' as UDP has no state.

Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    7759861 View commit details
    Browse the repository at this point in the history

  2. Change udp collector to use prometheus/procfs lib. Use prometheus/pro… 

    …cfs master branch as the dependencies for net_udp is not released.

Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    c39e187 View commit details
    Browse the repository at this point in the history

  3. Add missing logger parameter 

    Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    d7f4ab6 View commit details
    Browse the repository at this point in the history

  4. Rename file to collector name. Add cli flags to disable either the co… 

    …llection of ipv4 based queues or ipv6 based queues.

Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    81ca4ae View commit details
    Browse the repository at this point in the history

  5. Remove old collector file. 

    Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    51ff074 View commit details
    Browse the repository at this point in the history

  6. Update help text and error message for the cli flags. 

    Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    99769c8 View commit details
    Browse the repository at this point in the history

  7. Remove cli flags. Add no data errors for ipv4 and ipv6. 

    Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    03ececf View commit details
    Browse the repository at this point in the history

  8. Remove newly insert errors, but use ErrNoData instead. 

    Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    f8fdaaa View commit details
    Browse the repository at this point in the history

  9. Fix identical expression in if statement. 

    Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    fe4ac8b View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2020

  1. Change to default collector. Update e2e tests. Update readme and chan… 

    …gelog.

Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
    Peter Bueschel committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    b77425c View commit details
    Browse the repository at this point in the history