new flag to disable all default collectors #1460
Conversation
Signed-off-by: Paul Gier <pgier@redhat.com>
pgier
force-pushed
the
disable-default-collectors
branch
from
6b4da13 to
20782de
Compare
|
I was thinking about doing this by making the const |
|
Maybe I'm missing something, but I'm not sure how that would work because the collectors need to register themselves with the enabled/disabled flag before the flags are parsed. So you wouldn't know whether to set |
|
@pgier Can you resolve the conflicts for this? I'm getting ready to release 1.0.0 and I think this should go in. |
Signed-off-by: Ben Kochie <superq@gmail.com>
|
Yay finally :) |
|
Why isn't the --collector.disable-defaults flag documented here in the README.md? |
|
I think @SuperQ didn't want to promote usage of that. But not sure. I'd say it should be documented. |
|
I haven't been able to find any documentation on how to use this. Is it as simple as specifying --collector.disable-defaults followed by --collector flags for whatever we want enabled? For example: ExecStart=/opt/node_exporter/node_exporter ? |
|
No, I just forgot to update the README with the new flag option. |
|
Hi there! Took me quite a while to find this feature. Can maybe this be updated here? https://github.com/prometheus/node_exporter#collectors. That's where I was hoping to find something about it at least. For what is worth, my use-case is using node_exporter with nothing but the textfile collector... come to think of it, maybe I should just run an nginx or something like that... feels "righter" to use something from the Prom ecosystem though. I can PR of course, just want to check first if that's OK. Awesome work by the way. |
|
@tiagosimao Good point! Yeah would be great if you can submit a PR to mention the flag. |
Took me ages to find this thing since there's literally nearly 100 other options that look almost the same. prometheus#1460 (comment) some other person wants this as well. :) Signed-off-by: Nick Irvine <nick@segment.com>
* new flag to disable all default collectors Signed-off-by: Paul Gier <pgier@redhat.com> Co-authored-by: Ben Kochie <superq@gmail.com>
Took me ages to find this thing since there's literally nearly 100 other options that look almost the same. prometheus#1460 (comment) some other person wants this as well. :) Signed-off-by: Nick Irvine <nick@segment.com>
* new flag to disable all default collectors Signed-off-by: Paul Gier <pgier@redhat.com> Co-authored-by: Ben Kochie <superq@gmail.com>
Took me ages to find this thing since there's literally nearly 100 other options that look almost the same. prometheus#1460 (comment) some other person wants this as well. :) Signed-off-by: Nick Irvine <nick@segment.com>
No description provided.