Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdadm: Add test case for syncing RAID 6 #1080

Closed
wants to merge 1 commit into from
Closed

mdadm: Add test case for syncing RAID 6 #1080

wants to merge 1 commit into from

Conversation

corny
Copy link
Contributor

@corny corny commented Sep 19, 2018

In case of RAID 6 the amount of syncable blocks differs from the total amount of blocks.
The exported metrics can not be used to calculate the synchronization progress.

Is that the expected behaviour? Or do we need a new metric for syncable blocks?

The amount of syncable blocks differs from the total amount of blocks.

Signed-off-by: Julian Kornberger <jk+github@digineo.de>
@@ -11,18 +11,22 @@ md0 : active raid1 sdi1[0] sdj1[1]
md4 : inactive raid1 sda3[0] sdb3[1]
4883648 blocks [2/2] [UU]

md6 : active raid1 sdb2[2] sda2[0]
md5 : active raid1 sdb2[2] sda2[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave these unchanged, so that the diff is easier to read. Maybe name the new one md5.

I would prefer do this cleanup as a separate noop PR for the end-to-end fixture changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll split my commit up.

@SuperQ
Copy link
Member

SuperQ commented Sep 19, 2018

Interesting, it looks like the "syncable" value is 3x the storage value in your example.

I guess we need to expose a separate metric that contains the "syncable" value.

@corny
Copy link
Contributor Author

corny commented Sep 19, 2018

Unfortunately the syncable blocks are only displayed during the synchronization.
What do you think about a new metric for the recovery process as percentage?

@SuperQ
Copy link
Member

SuperQ commented Sep 20, 2018

Yea, I think we're going to have to change the behavior of these metrics and only expose blocks_synced and blocks_syncable when a resync is active. This will be a breaking change, but thinking about it a bit more, I think we shouldn't assume that synced = total.

We should open an issue to discuss this.

@corny
Copy link
Contributor Author

corny commented Sep 25, 2018

Closed in favor of #1085

@corny corny closed this Sep 25, 2018
@corny corny deleted the mdadm-raid6 branch September 25, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants