-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu counter label mismatch between Darwin and FreeBSD? #414
Comments
Hmmmm, thinking about this more, it may not be useful to keep the same counter name across OS's. Pretty much everything other than CPU has different requirements, so using "one dashboard per OS" seems fairly mandatory for host monitoring. |
The FreeBSD name is the better name, and we'll likely be changing the Linux one over to that at some point in the future. |
No worries. 😄 |
I used node_cpu for darwin to stay consistent with linux, but yes the freebsd name is better. Guess it makes sense to renaming them all together at some point. Going to close this here in favor of #150 which discusses consolidating of the metrics. |
* fixed arp table mac address parsing - Added ARPEntry.Flags field related to entry flags - Added ARPEntry.IsComplete() to check if entry is complete - Fixed mac address parsing and error handling - Test improved with incomplete entry information Closes prometheus#413. Signed-off-by: Serhii Zasenko <sergii@zasenko.name> * Arp flag const names cleanup Signed-off-by: Serhii Zasenko <sergii@zasenko.name>
Trying out the new cpu counters on Darwin, the counter name is "node_cpu":
Looking at the cpu counter for FreeBSD, it seems to be called "node_cpu_seconds_total":
If they're for the same thing (seems to be?), shouldn't they use the same metric name to make things easier for cross-platform measurement comparison?
Pointing it out because it's making things a bit tricky with the default/example node exporter dashboards in Grafana. 😉
The text was updated successfully, but these errors were encountered: