Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor collectors to not depend of kingpin to be configured #774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor collectors to not depend of kingpin to be configured #774

wants to merge 1 commit into from

Commits on Oct 14, 2024

  1. Refactor collectors to not depend of kingpin to be configured. 

    This commit removes references to kingpin.CommandLine, allowing for the
collector package to be used and configured with a custom kingpin (or no
kingpin at all).

The configuration for collectors has been moved to struct fields, which
the kingpin flags populate at flag parse time.

Co-authored-by: Robert Fratto <robertfratto@gmail.com>
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
    @marctc @rfratto @cristiangreco
    2 people authored and cristiangreco committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1f5a899 View commit details
    Browse the repository at this point in the history