Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mysql_up metric #723

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Refactor mysql_up metric #723

merged 1 commit into from
Apr 12, 2023

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Apr 11, 2023

Use a return value on the scrape function to only send the mysql_up metric down the channel once.

@SuperQ
Refactor mysql_up metric
04224f2 
Use a return value on the scrape function to only send the `mysql_up`
metric down the channel once.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ
Copy link
Member Author

SuperQ commented Apr 11, 2023

Had this idea after I merged #722. CC @LeoQuote

@SuperQ SuperQ requested a review from Nexucis April 11, 2023 18:15
Nexucis
Nexucis approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that looks cleaner to me !

@SuperQ SuperQ merged commit 35ddd2b into main Apr 12, 2023
@SuperQ SuperQ deleted the superq/scrape_up branch April 12, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nexucis Nexucis Nexucis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperQ @Nexucis