Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow exporting dates as timestamps grom GLOBAL STATUS #561

Merged
merged 4 commits into from
Jul 20, 2021
Merged

allow exporting dates as timestamps grom GLOBAL STATUS #561

merged 4 commits into from
Jul 20, 2021

Conversation

mmiller1
Copy link
Contributor

@mmiller1 mmiller1 commented Jul 2, 2021

This will allow the exporter to report dates in the format of timestamps to prometheus. Fixes #457

Signed-off-by: mamiller <mamiller@rosettastone.com>
Signed-off-by: mamiller <mamiller@rosettastone.com>
collector/collector.go Outdated Show resolved Hide resolved
Signed-off-by: mamiller <mamiller@rosettastone.com>
collector/collector.go Outdated Show resolved Hide resolved
Signed-off-by: mamiller <mamiller@rosettastone.com>
@mmiller1
Copy link
Contributor Author

Hi @SuperQ, is there anything else I can do to help get this moved forward?

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just haven't had time to review. Thanks for the ping.

LGTM

@SuperQ SuperQ merged commit 9a2abc2 into prometheus:master Jul 20, 2021
@mmiller1
Copy link
Contributor Author

mmiller1 commented Aug 6, 2021

howdy @SuperQ - sorry to bother, I was wondering what the release process looks like for this exporter, and if there was a timeline or set of criteria that needs to be met before a new official release is cut. Thanks!

@SuperQ
Copy link
Member

SuperQ commented Aug 6, 2021

No bother. Sorry it takes a bit, I don't have as much time to spend on this as I wish. And I haven't found other people to dedicate the time.

I'll see what I can get done soon.

SuperQ added a commit that referenced this pull request Jan 5, 2022
BREAKING CHANGES:

Metric names in the info_schema.processlist collector have been changed. #603
Metric names in the info_schema.replica_host collector have been changed. #496

* [CHANGE] Rewrite processlist collector #603
* [FEATURE] Add collector for `replica_host_status` #496
* [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561
* [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577
* [BUGFIX] Fix logging issues #562 #602

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Jan 5, 2022
SuperQ added a commit that referenced this pull request Mar 3, 2022
BREAKING CHANGES:

Metric names in the info_schema.processlist collector have been changed. #603
Metric names in the info_schema.replica_host collector have been changed. #496

* [CHANGE] Rewrite processlist collector #603
* [FEATURE] Add collector for `replica_host_status` #496
* [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561
* [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577
* [BUGFIX] Fix logging issues #562 #602

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Mar 3, 2022
BREAKING CHANGES:

Metric names in the info_schema.processlist collector have been changed. #603
Metric names in the info_schema.replica_host collector have been changed. #496

* [CHANGE] Rewrite processlist collector #603
* [FEATURE] Add collector for `replica_host_status` #496
* [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561
* [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577
* [BUGFIX] Fix logging issues #562 #602

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Mar 3, 2022
BREAKING CHANGES:

Metric names in the info_schema.processlist collector have been changed. #603
Metric names in the info_schema.replica_host collector have been changed. #496

* [CHANGE] Rewrite processlist collector #603
* [FEATURE] Add collector for `replica_host_status` #496
* [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561
* [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577
* [BUGFIX] Fix logging issues #562 #602

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Mar 4, 2022
BREAKING CHANGES:

Metric names in the info_schema.processlist collector have been changed. #603
Metric names in the info_schema.replica_host collector have been changed. #496

* [CHANGE] Rewrite processlist collector #603
* [FEATURE] Add collector for `replica_host_status` #496
* [ENHANCEMENT] Expose dates as timestamps grom GLOBAL STATUS #561
* [BUGFIX] Fix mysql_slave_hosts_info for mysql 5.5 and mariadb 10.5 #577
* [BUGFIX] Fix logging issues #562 #602

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: include collection of SSL expiration from SHOW GLOBAL STATUS output
2 participants