Extend tests to validate metric name and help field #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2021 14:18
Signed-off-by: Guido Iaquinti <giaquinti@slack-corp.com>
Signed-off-by: Guido Iaquinti <giaquinti@slack-corp.com>
|
@SuperQ please let me know if you are interested in this and I'll rebase. Otherwise I'll simply close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend
collector/collector_test.goby adding validations to thefqNameandhelpfields.Why
While working on a PR to extend
collector/global_variables.goI've introduced a breaking change not spotted by the current tests.Note: tests are going to be more verbose but I consider this 👍 as a change in a metric name should be considered an incompatible API change.
Tests
Tests are passing.