fix info_schema_processlist collector, binlog dump may cause ‘write to net‘ a huge number #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 26, 2019 11:51
…ate check because binlog dump can in writing to net state, which cause this state be a very large number Signed-off-by: wuxu92 <wuxu92@qq.com>
Signed-off-by: wuxu92 <wuxu92@qq.com>
|
That seems like a problem with the alert, not with the exporter. I don't see anything invalid about this. |
IMHO, it would be better to add all binlog dump threads to |
|
Fixed with #603. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when binlog dump thread in 'writing to net' state, the value of metric
'mysql_info_schema_threads_seconds_by_user{state='writing to net'}'can be a very huge number, which firing meaningless alerts.move binlog dump cmd check before nomrmal state checker.