-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics for the output of "SHOW SLAVE HOSTS" #279
Conversation
CI breaking is due to an extra dependency that is not vendored |
How do I get the DCO sign off? Do I have to sign the initial commit somehow? (presumably by a squash or history rewrite of some kind?) Also how do I do the vendoring? |
All commits must contain the |
…utput of "SHOW SLAVE HOSTS" Add uuid dependency to vendoring Signed-off-by: Aaron George <aarongeorge@me.com> Add metrics for the output of "SHOW SLAVE HOSTS" Add uuid dependency to vendoring Signed-off-by: Aaron George <aarongeorge@me.com>
Thanks @SuperQ just need to work out this vendoring issue now |
collector/slave_hosts.go
Outdated
|
||
import ( | ||
"database/sql" | ||
"github.com/satori/go.uuid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We normally put an empty line between Go standard libraries and external libraries.
It looks like there are a couple of |
It looks like you've included the vendor package as a git submodule. For this project we're using
|
Fix formatting Signed-off-by: Aaron George <aarongeorge@me.com>
It looks like you need to delete that submodule stuff first before doing the govendor, as govendor isn't able to write out the vendor files. |
Signed-off-by: Aaron George <aarongeorge@me.com>
Thanks @SuperQ, those builds are succeeding now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
Oh, sorry, I forgot one more thing. Can you document the new collector in the top level |
Signed-off-by: Aaron George <aarongeorge@me.com>
@SuperQ Added to the arguments table |
@SuperQ is this OK to go or are there some additional changes required? |
Oh, sorry! This looks great. |
Closes: #267
Adds a new sub system to show data about the output of
SHOW SLAVE HOSTS
. This command shows currently running slaves from the master, however it can be presented in two seperate formats;This is from an old version of MySQL
This is from a new version of MySQL
This PR is designed to work with both. However the old version does not contain a slave UUID field, so it is left as an empty string.
This exposes one new metric called
mysql_slave_hosts_info
. As described in #267 the output is like;