Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSL settings don't allow enabling TLS or skip verification without custom ca #673

Closed
bluebrown opened this issue Oct 8, 2022 · 0 comments · Fixed by #718
Closed

SSL settings don't allow enabling TLS or skip verification without custom ca #673

bluebrown opened this issue Oct 8, 2022 · 0 comments · Fixed by #718

Comments

@bluebrown
Copy link
Contributor

The SSL related configuration is buggy. The culprit is that this method does not return the TLS query parameter in mos cases, where it actually should.

mysqld_exporter/config/config.go

Line 172 in 503f1fa

func (m MySqlConfig) FormDSN(target string) (string, error) {

Additionally, I could not get it working even when providing a custom CA. The client would always get errors from the server saying that TLS is required.
@bluebrown bluebrown mentioned this issue Oct 8, 2022
Closed
@SuperQ SuperQ mentioned this issue Mar 16, 2023
Merged
SuperQ pushed a commit that referenced this issue Mar 16, 2023
@soara @bluebrown
Add MySQL TLS configurations (#718)
ac1c2d6 
This PR is a modified version of the #674 to match the FormDSN supported by the #708.

Fixes: #673

Signed-off-by: Nico Braun <rainbowstack@gmail.com>
Signed-off-by: Yasushi MIYAZAKI <MIYAZAKI.Yasushi@gmail.com>
Co-authored-by: Nico Braun <rainbowstack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bluebrown