Change default validation scheme to UTF8Validation #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #723 Signed-off-by: Owen Williams <owen.williams@grafana.com>
ywwg
force-pushed
the
owilliams/defaultscheme
branch
from
435605e to
babb979
Compare
|
Is there any coordination with client_golang we need here? This seems like it may be a transparent breaking change for some systems. |
|
I'll test it out -- probably yes we want to coordinate releases |
bwplotka
approved these changes
Dec 5, 2024
|
The challenge is UnmarshalJSON and so, plus doing this in backward compatible way. Unless we want to add more validation scheme OR the cases where legacy has to be used, it might be indeed easier to break everyone here ): |
|
Added big warning to release https://github.com/prometheus/common/releases/tag/v0.62.0 |
bwplotka
added a commit
to prometheus/client_golang
that referenced
this pull request
Jan 20, 2025
common 0.62.0 switches NameValidationScheme global variable to UTF8Validation. While relaxing validation this will likely yield test failures downstream. It's unfortunate, but the alternatives were worse: prometheus/common#724 Good news is that client_golang should work with older common deps and callers can easily change model.NameValidationScheme value to old value to solve any compatibility issues. Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
added a commit
to prometheus/client_golang
that referenced
this pull request
Jan 20, 2025
common 0.62.0 switches NameValidationScheme global variable to UTF8Validation. While relaxing validation this will likely yield test failures downstream. It's unfortunate, but the alternatives were worse: prometheus/common#724 Good news is that client_golang should work with older common deps and callers can easily change model.NameValidationScheme value to old value to solve any compatibility issues. Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
added a commit
to prometheus/client_golang
that referenced
this pull request
Jan 20, 2025
common 0.62.0 switches NameValidationScheme global variable to UTF8Validation. While relaxing validation this will likely yield test failures downstream. It's unfortunate, but the alternatives were worse: prometheus/common#724 Good news is that client_golang should work with older common deps and callers can easily change model.NameValidationScheme value to old value to solve any compatibility issues. Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
added a commit
to prometheus/client_golang
that referenced
this pull request
Jan 20, 2025
common 0.62.0 switches NameValidationScheme global variable to UTF8Validation. While relaxing validation this will likely yield test failures downstream. It's unfortunate, but the alternatives were worse: prometheus/common#724 Good news is that client_golang should work with older common deps and callers can easily change model.NameValidationScheme value to old value to solve any compatibility issues. Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
added a commit
to prometheus/client_golang
that referenced
this pull request
Jan 20, 2025
common 0.62.0 switches NameValidationScheme global variable to UTF8Validation. While relaxing validation this will likely yield test failures downstream. It's unfortunate, but the alternatives were worse: prometheus/common#724 Good news is that client_golang should work with older common deps and callers can easily change model.NameValidationScheme value to old value to solve any compatibility issues. Signed-off-by: bwplotka <bwplotka@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #723