extend baseLogger functions and by adding SetFormat and SetLevel #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine Huret <ahuret@skilld.cloud>
ahuret
force-pushed
the
extend-default-logger-functions
branch
from
5ac5e5a
to
a1e5759
Compare
|
This is a deprecated and set to be deleted old internal logging library of Prometheus, you shouldn't be using it. |
|
right. I gonna close it, and propose a contribution to promlog logger. thx. |
alanprot
pushed a commit
to alanprot/common
that referenced
this pull request
Mar 15, 2023
On projects consuming this module as a library, gRPC might be set at newer versions where the deprecated #WithBalancerName has been removed already. Given that the version used by this module already offers a forward-compatible method, this commit uses that instead of the deprecated #WithBalancerName. This is a simplified version of prometheus#240, without touching the gRPC versions. Fixes prometheus#239 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
SetFormatandSetLevelfunctions tobaseLogger.