Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stringify non-string job names in push client #296

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Stringify non-string job names in push client #296

merged 2 commits into from
Oct 7, 2023

Commits on Oct 7, 2023

  1. Stringify non-string job names in push client 

    We do this to all other label values in the client and we should make
this one consistent. Right now it's particularly surprising that passing
a symbol as the job name results in an error like:

```
undefined method `include?' for :foo:Symbol (NoMethodError)
```

Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
    @Sinjo
    Sinjo committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    ca53b57 View commit details
    Browse the repository at this point in the history

  2. Add pending change to README.md 

    Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
    @Sinjo
    Sinjo committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    2f5422c View commit details
    Browse the repository at this point in the history