Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using lowercase for HTTP headers to make it compatible with HTTP/2 and Rack v3 #271

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Using lowercase for HTTP headers to make it compatible with HTTP/2 and Rack v3 #271

merged 1 commit into from
Dec 24, 2022

Conversation

bitmaybewise
Copy link
Contributor

@bitmaybewise bitmaybewise commented Dec 20, 2022 •
edited
Loading

Given Rack is validating HTTP headers has no uppercased letters, as mentioned in this previous PR #268, the exporter needs to use lowercased letters to keep compatibility.

@bitmaybewise
using lowercase for http headers to make it compatible with rack v3
07344f9 
Signed-off-by: Hercules Merscher <hlmerscher@gmail.com>
@bitmaybewise bitmaybewise mentioned this pull request Dec 20, 2022
Merged
2 tasks
Sinjo
Sinjo approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@Sinjo Sinjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in!

Out of an unreasonable level of paranoia, I've just done a quick check that Promethus still scrapes our example app with these changes, and everything is fine.

@Sinjo Sinjo merged commit d2987f1 into prometheus:main Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sinjo Sinjo Sinjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitmaybewise @Sinjo