Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG in preparation for 2.2.0 release #228

Closed
wants to merge 1 commit into from

Conversation

dmagliola
Copy link
Collaborator

@dmagliola dmagliola commented Jun 19, 2021

Includes the changes in master that we'll release in 2.2.0, and
the ones that we can't because of breaking changes, which we'll release
in 3.0.0


I'm proposing to release a new version with the bug fixes and backwards-compatible improvements we've introduced (which we should have released ages ago, but life), including the not-yet-merged fix to with_labels in #227.

Since master has many non-releasable changes, I've created branch v2.2_release, which forks off of 2.1.0 and has the relevant commits cherry-picked into it.

Comparison between 2.2.0 (cherry-picked commits) vs 2.1.0

Once we finish the changes to PushGateway, we'll release v3.0 with what's in master right now.


NOTE: Do not merge this yet. If @Sinjo agrees with this approach, I'll update this README with the correct, date, merge, and add a new release tag in the v2.2_release branch

Includes the changes in `master` that we'll release in `2.2.0`, and
the ones that we can't because of breaking changes, which we'll release
in `3.0.0`

Signed-off-by: Daniel Magliola <dmagliola@crystalgears.com>
@Sinjo
Copy link
Member

Sinjo commented Jul 9, 2021

Changelog looks good. I'll add the other pushgateway changes to it when I get a moment to do them.

I think there might be some commits missing from the branch though? At the very least I'd expect to see all three from this PR once it's merged. Haven't looked through the others, but I wanted to check how you chose which commits to cherry pick before I do.

@dmagliola
Copy link
Collaborator Author

dmagliola commented Jul 13, 2021

I'd expect to see all three from this PR once it's merged

Well, yes, but it's not merged, so they may change :D

My question is whether the way the branch is set up / the general approach is how you'd do it.

I wanted to check how you chose which commits to cherry pick before I do.

Everything in master that is non-breaking that changes behaviour (so i didn't cherry pick changes to README, Contributors, etc)

@Sinjo
Copy link
Member

Sinjo commented Sep 9, 2021

Alright, settled in enough at the new job to have time to think about this again. The general approach looks right.

I would say it's worth grabbing the readme changes too, if it's not a huge faff, to avoid any confusion when viewing the release on GitHub.

@Sinjo Sinjo changed the title Update CHANGELOG in preparation for 2.2.0 release Update CHANGELOG and version for 3.0.0 release Jan 27, 2022
@Sinjo Sinjo changed the title Update CHANGELOG and version for 3.0.0 release Update CHANGELOG in preparation for 2.2.0 release Jan 27, 2022
@Sinjo
Copy link
Member

Sinjo commented Jan 28, 2022

I've included the commit from this branch in #244, and added the other changes needed now that we're going straight to a 3.0.0 release.

@Sinjo Sinjo closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants