observed value should be stored the bucket

whose value is same as the observed value Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
prometheus · Jan 8, 2020 · c931a04 · c931a04
1 parent 7129453
commit c931a04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/prometheus/client/histogram.rb b/lib/prometheus/client/histogram.rb
@@ -47,7 +47,7 @@ def type
       end
 
       def observe(value, labels: {})
-        bucket = buckets.find {|upper_limit| upper_limit > value  }
+        bucket = buckets.find {|upper_limit| upper_limit >= value  }
         bucket = "+Inf" if bucket.nil?
 
         base_label_set = label_set_for(labels)

diff --git a/spec/prometheus/client/histogram_spec.rb b/spec/prometheus/client/histogram_spec.rb
@@ -140,10 +140,12 @@
     it 'returns a hash of all recorded summaries' do
       histogram.observe(3, labels: { status: 'bar' })
       histogram.observe(6, labels: { status: 'foo' })
+      histogram.observe(10, labels: { status: 'baz' })
 
       expect(histogram.values).to eql(
         { status: 'bar' } => { "2.5" => 0.0, "5" => 1.0, "10" => 1.0, "+Inf" => 1.0, "sum" => 3.0 },
         { status: 'foo' } => { "2.5" => 0.0, "5" => 0.0, "10" => 1.0, "+Inf" => 1.0, "sum" => 6.0 },
+        { status: 'baz' } => { "2.5" => 0.0, "5" => 0.0, "10" => 1.0, "+Inf" => 1.0, "sum" => 10.0 },
       )
     end
   end