Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated README installation command #833

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

alexagriffith
Copy link
Contributor

The command says pip install prometheus_client (underscore) but the steps above and PyPi says prometheus-client (dash)

Signed-off-by: Alexa Griffith agriffith96@gmail.com

The command says pip install prometheus_client (underscore) but the steps above and PyPi says prometheus-client (dash) 

Signed-off-by: Alexa Griffith  <agriffith96@gmail.com>
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do note you will need to sign the DCO in order for this to be merged.

@csmarchbanks
Copy link
Member

Closing and reopen as it looks like you did sign the DCO and I am hoping that it passes this time.

@csmarchbanks csmarchbanks reopened this Aug 19, 2022
@csmarchbanks csmarchbanks merged commit f17a836 into prometheus:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants