Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1037, where comparison between
Timestamp
were wrong.I've chosen this solution after testing different ones because it is the faster one. Files and speed tests here.
Different implementations:
Changing the full class by a namedtuple
Here there is no need to implement comparison operators because they are already implemented in the parent class.
This was the worse implementation, around 50% slower than the chosen one.
tuples
logical operators