Change links on front page to be relative #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the endpoint of the exporter is mapped to a subpath by a reverse proxy, absolute links would break. Relative links continue to work. Co-authored-by: Karina Calma <karina_calma@infobest.ro> Signed-off-by: Martin Bickel <martin.bickel@continental.com>
|
@MaBiConti merged. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fstab , @dhoard , @tomwilkie
On the machines running JMX_Exporter, we are using a reverse proxy to perform TLS termination.
When mapping the JMX_Exporter to a subpath with the reverse proxy (e.g. https://myhostname/jmx/ ), the links on the frontpage of JMX_Exporter will break, as they are currently absolute links pointing to pagesin the root.
This PR changes them to be relative, so they will continue to work on a subpath.