Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #887: Sort histogram bounds before validation #888

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

turchenkoalex
Copy link
Contributor

@turchenkoalex turchenkoalex commented Nov 1, 2023

Fixed issue #887

Do sorting after the bounds array is filled. And added to the unit test the bucket value at which the error occurred.

Signed-off-by: Aleksandr Turchenko <aleksandr.turchenko@lightspeedhq.com>
Copy link
Member

@fstab fstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks a lot!

@fstab fstab merged commit c4dc833 into prometheus:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants