Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch sparse histograms to base-2 buckets #886

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Commits on Jun 23, 2021

  1. Switch to base-2 buckets

    This seem what OTel is converging towards, see
    open-telemetry/oteps#149 .
    
    I see pros and cons with base-10 vs base-2. They are discussed in
    detail in that OTel PR, and the gist of the discussion is pretty much
    in line with my design doc. Since the balance is easy to tip here, I
    think we should go with base-2 if OTel picks base-2. This also seems
    to be in agreement with several proprietary solution (see again the
    discussion on that OTel PR.)
    
    The idea to make the number of buckets per power of 2 (or formerly 10)
    a power of 2 itself was also sketched out in the design doc
    already. It guarantees mergeability of different resolutions. I was
    undecided between making it a recommendation or mandatory. Now I think
    it should be mandatory as it has the additional benefit of playing
    well with OTel's plans.
    
    This commit also addresses a number of outstanding TODOs.
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    31318b7 View commit details
    Browse the repository at this point in the history
  2. Add tests for sparse histogram

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    6c4e0ef View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Pin client_model to the most recent sparsehistogram commit

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    5142344 View commit details
    Browse the repository at this point in the history