Only set start/end if the time is not Zero #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes prometheus#614 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
jacksontj
added a commit
to jacksontj/client_golang
that referenced
this pull request
Mar 21, 2023
This is an updated PR of prometheus#615 -- based on discussion in prometheus#621 Fixes prometheus#621
jacksontj
added a commit
to jacksontj/client_golang
that referenced
this pull request
Mar 21, 2023
This is an updated PR of prometheus#615 -- based on discussion in prometheus#621 Fixes prometheus#621 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
jacksontj
added a commit
to jacksontj/client_golang
that referenced
this pull request
Mar 21, 2023
This is an updated PR of prometheus#615 -- based on discussion in prometheus#621 Fixes prometheus#621 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
jacksontj
added a commit
to jacksontj/client_golang
that referenced
this pull request
Mar 21, 2023
This is an updated PR of prometheus#615 -- based on discussion in prometheus#621 Fixes prometheus#621 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #614
Signed-off-by: Thomas Jackson jacksontj.89@gmail.com
This will allow clients to decide when they want to send a time vs letting prometheus do all of the time.