process_collector: merge wasip1 and js into a single implementation #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying WANG <ying.wang@grafana.com>
ying-jeanne
force-pushed
the
further-cleanup
branch
from
d20b2f4 to
426a90e
Compare
ying-jeanne
changed the title
amberpixels
pushed a commit
to amberpixels/prometheus_client_golang
that referenced
this pull request
Nov 29, 2024
…rometheus#1644) Signed-off-by: Ying WANG <ying.wang@grafana.com> Signed-off-by: Eugene <eugene@amberpixels.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1591
Following the instructions in PR #1625, I am merging the WASI and JS process collector implementations into a unified file to reduce code duplication and complete the original ticket.
@bwplotka @ArthurSens @kakkoyun