Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Go versions #1602

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Update supported Go versions #1602

merged 1 commit into from
Aug 31, 2024

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Aug 30, 2024

Now that 1.23 is out, update the supported version matrix to Go 1.21 through 1.23. This allows us to start using log/slog.

  • Update generated tests.

@SuperQ SuperQ requested a review from ArthurSens August 30, 2024 14:57
@ArthurSens
Copy link
Member

Hmmm, strange that we got failing tests with 1.23 🤔

We also want to generate the tests for new metrics for gocollector with 1.23. We have generation scripts[1][2] for that but the result[3] is showing that we've changed the generated files manually and CI didn't block it 😬.

I'm not sure how to proceed here, but it seems like we need to work on this[4] before updating the go version?

@SuperQ SuperQ force-pushed the superq/update_go branch 3 times, most recently from d0f97e2 to cb25d7a Compare August 31, 2024 20:23
@SuperQ
Copy link
Member Author

SuperQ commented Aug 31, 2024

I've re-generate and manually fixed up the tests. I'd rather not block keeping things up-to-date on automation technical debt.

I need this for #1601.

When the review here is complete, I will update the required tests, as this is manually done in the GitHub UI.

Now that 1.23 is out, update the supported version matrix to Go 1.21
through 1.23. This allows us to start using `log/slog`.
* Update generated tests.

Signed-off-by: SuperQ <superq@gmail.com>
@ArthurSens
Copy link
Member

I've re-generate and manually fixed up the tests. I'd rather not block keeping things up-to-date on automation technical debt.

I need this for #1601.

When the review here is complete, I will update the required tests, as this is manually done in the GitHub UI.

Fair point. We can work on the automation later

@ArthurSens ArthurSens merged commit 0a90db7 into main Aug 31, 2024
12 checks passed
@ArthurSens ArthurSens deleted the superq/update_go branch August 31, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants