Build break after updating #1446

jimsnab · 2024-02-23T00:42:33Z

./../../go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/push/push.go:112:22: undefined: expfmt.FmtProtoDelim

Seems to be because of

github.com/prometheus/common v0.45.0 => v0.48.0

My project has github.com/snowflakedb/snowflake v1.8.0 which pulls in so many (unwanted) dependencies, including AWS SDK. It seems this break comes in by picking up the AWS sdk v1.25.1.

go: upgraded github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.0 => v1.6.1
go: upgraded github.com/aws/aws-sdk-go-v2/credentials v1.17.0 => v1.17.3
go: upgraded github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.16.2 => v1.16.5
go: upgraded github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.0 => v1.3.1
go: upgraded github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.0 => v2.6.1
go: upgraded github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.0 => v1.3.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.0 => v1.11.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.3.0 => v1.3.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.0 => v1.11.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.17.0 => v1.17.1
go: upgraded github.com/aws/aws-sdk-go-v2/service/s3 v1.50.1 => v1.51.0
go: upgraded github.com/aws/smithy-go v1.20.0 => v1.20.1
go: upgraded github.com/klauspost/compress v1.17.6 => v1.17.7
go: upgraded github.com/klauspost/cpuid/v2 v2.2.6 => v2.2.7
go: upgraded github.com/prometheus/client_model v0.5.0 => v0.6.0
go: upgraded github.com/prometheus/common v0.45.0 => v0.48.0
go: upgraded golang.org/x/exp v0.0.0-20240213143201-ec583247a57a => v0.0.0-20240222234643-814bf88cf225
go: upgraded google.golang.org/protobuf v1.31.0 => v1.32.0

Obviously swimming in all these versions is difficult to diagnose, so I'm not sure what's wrong.

Update: looks like the following change made FmtProtoDelim private.

prometheus/common@v0.47.0...v0.48.0

The text was updated successfully, but these errors were encountered:

jimsnab · 2024-02-23T00:54:50Z

@ywwg is this break from your change? prometheus/common@05d7387

erdii · 2024-02-23T13:51:13Z

The same happens when using the promlint package:

# github.com/prometheus/client_golang/prometheus/testutil/promlint
$HOME/go/pkg/mod/github.com/prometheus/client_golang@v1.18.0/prometheus/testutil/promlint/promlint.go:71:38: undefined: expfmt.FmtText
FAIL	package-operator.run/internal/metrics [build failed]
FAIL

Go version: go version go1.22.0 linux/amd64
Links to:

used go.mod
used go.sum

[1] prometheus/client_golang#1446

…/common because of [1] [1] prometheus/client_golang#1446 Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>

Fixes prometheus#1446 Signed-off-by: Owen Williams <owen.williams@grafana.com>

nicolaasuni-vonage · 2024-02-26T12:13:12Z

Ref.: prometheus/common#577

It looks like this change has to be tagged in order to solve the issue.

nicolaasuni-vonage · 2024-02-27T11:31:44Z

Would you please reopen this issue and keep it open until the problem is actually fixed?
Or the issue should be addressed only by prometheus/common prometheus/common#577 ?

ArthurSens · 2024-02-27T18:46:01Z

There you go!

https://github.com/prometheus/client_golang/releases/tag/v1.19.0

nicolaasuni-vonage · 2024-02-28T13:50:37Z

Thank you.

* Use cardboard instead of mage * Add do shorthand for cardboard and use it in pipeline * Do not force docker for pipeline integration tests * Change commands, add docs * Name Integration tests ci target correctly * Remove obsolete release target * Fix integration tests * Fix do * Import real cardboard, remove devkube and mage imports * Fix int and unit tests * Join github action jobs and also you int coverage reports * in ci use caching of setup-go instead of an extra step * Fixes from review with the josh * Let CI check if lint changes files * Add dev.Create target * Remove cardboard release taret * Use most recent cardboard * Use filepath.Join everywhere in cmd/build * Use go1.22 * Fix linter hit that occured on rebase * Fix integration tests not working * Increase wait timeout for pko bootstrapping to 5mins since CI is slow * Split cardboard main.go file * clean up sweep Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * more update * cmd/build: clean up compilation flags - add `-buildid=` on top of trimpath to get one step closer towards reproducible builds golang/go#16860 - don't panic! (and return the error instead) Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * cmd/build: make int tests run again Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * decouple objecttemplate test (which for some reason includes a test for the `environment` capabilities of PKO) from used kubernetes version by fetching the cluster version from the apiserver insteadad of hardcoding it Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * clean up sweep² Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * make ci:release work almost 100% Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * cmd/build: make arch configurable for binary image builds and use host arch for building integration test images Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * fix release dependency ordering Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * cmd/build: remove forgotten hardcoded amd64 from buildImage Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * update to cardboard release v0.0.1 * bump cardboard dependency to v0.0.2 to downgrade github.comprometheus/common because of [1] [1] prometheus/client_golang#1446 Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * cmd/build: move .cache into a const and run mkdir -p .cache/integration before running the integration tests Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> * burrrrrrito Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> --------- Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com> Co-authored-by: Nico Schieder <nschieder@redhat.com> Co-authored-by: Alessandro Costa <alecosta.me@gmail.com> Co-authored-by: Josh Gwosdz <jgwosdz@redhat.com>

Upgrade is necessary because prometheus introduced incompatible changes prometheus/client_golang#1446

poszu mentioned this issue Feb 23, 2024

build(deps): Bump github.com/prometheus/common from 0.47.0 to 0.48.0 spacemeshos/go-spacemesh#5596

Closed

This was referenced Feb 23, 2024

chore(deps): bump github.com/prometheus/common from 0.47.0 to 0.48.0 go-faster/oteldb#340

Closed

deps: bump prometheus/common version #1447

Closed

erdii added a commit to erdii/cardboard that referenced this issue Feb 23, 2024

downgrading prometheus-common back because of [1]

9202c9a

[1] prometheus/client_golang#1446

erdii mentioned this issue Feb 23, 2024

downgrading prometheus-common back because of [1] package-operator/cardboard#78

Merged

erdii added a commit to erdii/cardboard that referenced this issue Feb 23, 2024

downgrading prometheus-common back because of [1]

4bda8e2

[1] prometheus/client_golang#1446

erdii added a commit to package-operator/cardboard that referenced this issue Feb 23, 2024

downgrading prometheus-common back because of [1] (#78)

44f2ae9

[1] prometheus/client_golang#1446

erdii added a commit to eqrx/package-operator that referenced this issue Feb 23, 2024

bump cardboard dependency to v0.0.2 to downgrade github.comprometheus…

ff877a4

…/common because of [1] [1] prometheus/client_golang#1446 Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>

ywwg mentioned this issue Feb 23, 2024

deps: bump prometheus/common version #1448

Merged

ywwg added a commit to ywwg/client_golang that referenced this issue Feb 23, 2024

deps: bump prometheus/common version

2696b90

Fixes prometheus#1446 Signed-off-by: Owen Williams <owen.williams@grafana.com>

ywwg added a commit to ywwg/client_golang that referenced this issue Feb 23, 2024

deps: bump prometheus/common version

6d03920

Fixes prometheus#1446 Signed-off-by: Owen Williams <owen.williams@grafana.com>

ArthurSens closed this as completed in #1448 Feb 23, 2024

hansmi mentioned this issue Feb 23, 2024

Bump github.com/prometheus/common from 0.46.1-0.20240206181200-773d5664eb8d to 0.48.0 hansmi/prometheus-ai-on-the-edge-device-exporter#1

Closed

Reecepbcups mentioned this issue Mar 26, 2024

build(deps): bump prometheus and client_golang in v0.50.x cosmos/cosmos-sdk#19873

Closed

12 tasks

jiping-s added a commit to relex/gotils that referenced this issue Apr 25, 2024

feat: Upgrade prometheus libraries and bump go to 1.21

27805b5

Upgrade is necessary because prometheus introduced incompatible changes prometheus/client_golang#1446

jiping-s mentioned this issue Apr 25, 2024

feat: Upgrade prometheus libraries and bump go to 1.21 relex/gotils#43

Merged

jiping-s added a commit to relex/gotils that referenced this issue Apr 25, 2024

feat: Upgrade prometheus libraries and bump go to 1.21 (#43)

ad2a7eb

Upgrade is necessary because prometheus introduced incompatible changes prometheus/client_golang#1446

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build break after updating #1446

Build break after updating #1446

jimsnab commented Feb 23, 2024 •

edited

Loading

jimsnab commented Feb 23, 2024

erdii commented Feb 23, 2024 •

edited

Loading

nicolaasuni-vonage commented Feb 26, 2024

nicolaasuni-vonage commented Feb 27, 2024 •

edited

Loading

ArthurSens commented Feb 27, 2024

nicolaasuni-vonage commented Feb 28, 2024

Build break after updating #1446

Build break after updating #1446

Comments

jimsnab commented Feb 23, 2024 • edited Loading

jimsnab commented Feb 23, 2024

erdii commented Feb 23, 2024 • edited Loading

nicolaasuni-vonage commented Feb 26, 2024

nicolaasuni-vonage commented Feb 27, 2024 • edited Loading

ArthurSens commented Feb 27, 2024

nicolaasuni-vonage commented Feb 28, 2024

jimsnab commented Feb 23, 2024 •

edited

Loading

erdii commented Feb 23, 2024 •

edited

Loading

nicolaasuni-vonage commented Feb 27, 2024 •

edited

Loading