Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2372] Move config reload metrics to Coordinator.Reload() #2373

Merged
merged 2 commits into from
Sep 28, 2020
Merged

[#2372] Move config reload metrics to Coordinator.Reload() #2373

merged 2 commits into from
Sep 28, 2020

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Sep 15, 2020

Closes #2372

Signed-off-by: Kevin Hellemun 17928966+OGKevin@users.noreply.github.com

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
@OGKevin OGKevin changed the title #2372 Move config reload metrics to Coordinator.Reload() [#2372] Move config reload metrics to Coordinator.Reload() Sep 15, 2020
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just a few nits and we're good.

Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
@simonpasquier
Copy link
Member

LGTM, will merge on green. Thanks!

@simonpasquier simonpasquier merged commit dd1a8fb into prometheus:master Sep 28, 2020
@OGKevin OGKevin deleted the #2372-move-config-reload-metrics branch September 28, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinator subscriber errors are excluded in alertmanager_config_last_reload_successful
2 participants