Fixed dispatcher metrics registration #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
3 tasks
gouthamve
approved these changes
Mar 6, 2020
mxinden
approved these changes
Mar 6, 2020
|
Thanks! |
|
Not supporting See #2202 |
gotjosh
added a commit
to gotjosh/cortex
that referenced
this pull request
Aug 24, 2020
Signed-off-by: gotjosh <josue@grafana.com>
gouthamve
pushed a commit
to cortexproject/cortex
that referenced
this pull request
Aug 24, 2020
#3065) * Remove TODO about prometheus/alertmanager#2182 as it got merged Signed-off-by: gotjosh <josue@grafana.com> * Remove TODO about prometheus/alertmanager#2200 as it got merged Signed-off-by: gotjosh <josue@grafana.com> * Register the Alertmanager API metrics Signed-off-by: gotjosh <josue@grafana.com> * Add a changelog entry Signed-off-by: gotjosh <josue@grafana.com> * Fix tests Signed-off-by: gotjosh <josue@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new dispatcher metrics are not registered on the provided registerer, but on the default one. This PR fixes it, as well as handle the case the input registerer is
nil.