test: add time interval suppression metric checks for notify

Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
prometheus · Oct 20, 2023 · b3b0a32 · b3b0a32
1 parent 4df1a55
commit b3b0a32
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/notify/notify_test.go b/notify/notify_test.go
@@ -841,7 +841,8 @@ func TestTimeMuteStage(t *testing.T) {
 	}
 	m := map[string][]timeinterval.TimeInterval{"test": intervals}
 	intervener := timeinterval.NewIntervener(m)
-	stage := NewTimeMuteStage(intervener)
+	metrics := NewMetrics(prometheus.NewRegistry(), featurecontrol.NoopFlags{})
+	stage := NewTimeMuteStage(intervener, metrics)
 
 	outAlerts := []*types.Alert{}
 	nonMuteCount := 0
@@ -875,6 +876,10 @@ func TestTimeMuteStage(t *testing.T) {
 	if len(outAlerts) != nonMuteCount {
 		t.Fatalf("Expected %d alerts after time mute stage but got %d", nonMuteCount, len(outAlerts))
 	}
+	suppressed := int(prom_testutil.ToFloat64(metrics.numAlertsSuppressedTotal))
+	if (len(cases) - nonMuteCount) != suppressed {
+		t.Fatalf("Expected %d alerts counted in suppressed metric but got %d", len(outAlerts), suppressed)
+	}
 }
 
 func TestTimeActiveStage(t *testing.T) {
@@ -900,6 +905,11 @@ func TestTimeActiveStage(t *testing.T) {
 			labels:     model.LabelSet{"mute": "me"},
 			shouldMute: true,
 		},
+		{
+			fireTime:   "02 Dec 20 16:59 +0000",
+			labels:     model.LabelSet{"mute": "me"},
+			shouldMute: true,
+		},
 		{
 			// Tuesday before 5pm
 			fireTime:   "01 Dec 20 16:59 +0000",
@@ -926,7 +936,8 @@ func TestTimeActiveStage(t *testing.T) {
 	}
 	m := map[string][]timeinterval.TimeInterval{"test": intervals}
 	intervener := timeinterval.NewIntervener(m)
-	stage := NewTimeActiveStage(intervener)
+	metrics := NewMetrics(prometheus.NewRegistry(), featurecontrol.NoopFlags{})
+	stage := NewTimeActiveStage(intervener, metrics)
 
 	outAlerts := []*types.Alert{}
 	nonMuteCount := 0
@@ -960,6 +971,10 @@ func TestTimeActiveStage(t *testing.T) {
 	if len(outAlerts) != nonMuteCount {
 		t.Fatalf("Expected %d alerts after time mute stage but got %d", nonMuteCount, len(outAlerts))
 	}
+	suppressed := int(prom_testutil.ToFloat64(metrics.numAlertsSuppressedTotal))
+	if (len(cases) - nonMuteCount) != suppressed {
+		t.Fatalf("Expected %d alerts counted in suppressed metric but got %d", len(outAlerts), suppressed)
+	}
 }
 
 func BenchmarkHashAlert(b *testing.B) {