Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

fix windows tests #469

Merged

Conversation

krasi-georgiev
Copy link
Contributor

@krasi-georgiev krasi-georgiev commented Dec 11, 2018

closes: #420
Signed-off-by: Krasi Georgiev kgeorgie@redhat.com

Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
@krasi-georgiev krasi-georgiev force-pushed the windows-tests branch 3 times, most recently from adf7278 to c36a2f2 Compare December 11, 2018 13:03
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
Krasi Georgiev added 2 commits December 11, 2018 15:31
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
@krasi-georgiev krasi-georgiev mentioned this pull request Dec 11, 2018
@krasi-georgiev
Copy link
Contributor Author

still green even after 10 re-triggers.

Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
wal_test.go Outdated Show resolved Hide resolved
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
head.go Outdated Show resolved Hide resolved
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
wal_test.go Outdated Show resolved Hide resolved
Krasi Georgiev added 2 commits December 13, 2018 12:54
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
@krasi-georgiev
Copy link
Contributor Author

@gouthamve I have reverted the removed tests and disabled these for windows // +build !windows.
I think there is an actual bug in the old WAL, but this is as far as my motivation to fix this goes.

Copy link
Collaborator

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I'll try to remove the build tag when I get time.

@krasi-georgiev krasi-georgiev merged commit 2962202 into prometheus-junkyard:master Dec 13, 2018
@krasi-georgiev krasi-georgiev deleted the windows-tests branch May 17, 2019 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants