Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

Commit

Permalink
nits
Browse files Browse the repository at this point in the history
Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com>
  • Loading branch information
krasi-georgiev committed Jun 24, 2019
1 parent 64101d9 commit d78542a
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions block.go
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,7 @@ func writeMetaFile(logger log.Logger, dir string, meta *BlockMeta) error {

// The meta file is within a block so
// its size needs to be calcualted and set upfront.
err := setMetaFileSize(meta)
if err != nil {
if err := setMetaFileSize(meta); err != nil {
return err
}

Expand All @@ -265,8 +264,7 @@ func writeMetaFile(logger log.Logger, dir string, meta *BlockMeta) error {
}

var merr tsdb_errors.MultiError
_, err = f.Write(jsonMeta)
if err != nil {
if _, err = f.Write(jsonMeta); err != nil {
merr.Add(err)
merr.Add(f.Close())
return merr.Err()
Expand All @@ -275,6 +273,7 @@ func writeMetaFile(logger log.Logger, dir string, meta *BlockMeta) error {
// Force the kernel to persist the file on disk to avoid data loss if the host crashes.
if err := f.Sync(); err != nil {
merr.Add(err)
merr.Add(f.Close())
return merr.Err()
}
if err := f.Close(); err != nil {
Expand All @@ -285,7 +284,6 @@ func writeMetaFile(logger log.Logger, dir string, meta *BlockMeta) error {

// setMetaFileSize calculates and set the meta file size.
func setMetaFileSize(meta *BlockMeta) error {

jsonMeta, err := json.MarshalIndent(meta, "", "\t")
if err != nil {
return err
Expand Down

0 comments on commit d78542a

Please sign in to comment.