Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only query active_time on pg>=14 #1045

Merged

Conversation

MarcWort
Copy link
Contributor

Fixes #1044

Its quite hacky IMO, but please let me know what you think or how we could solve this otherwise.

Signed-off-by: MarcWort <113890636+MarcWort@users.noreply.github.com>
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would love to see an additional test for a version < 14, but I think this is sound.

@sysadmind sysadmind merged commit 49f66e1 into prometheus-community:master Jun 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column active_time missing in postgres < 14
2 participants