error if http method for home or config is not GET #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdii
force-pushed
the
guard-home-and-config-routes
branch
from
cf6403d
to
ec3fd77
Compare
Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
|
Sadly I cannot see the test results without logging in to CircleCI (which wants access to my private repos) :( |
…o anyways here Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
|
hahaaa it's me! somebody totally different who surely isn't @erdii with an empty profile!! |
bwplotka
approved these changes
Mar 4, 2021
Signed-off-by: Josh Gwosdz <jgwosdz@redhat.com>
|
nit resolved! :) your stage @bwplotka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally used
http://jiralert:9097/as webhook url in alertmanager and searched for a full day, wondering why neither alertmanager nor jiralert logged an error 😅I propose this fix as a future safeguard for other poor souls like me:
Check request method on the home and config endpoints and error out if it's not a GET request