[kube-prometheus-stack] Add downward compat for Prom CRD #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… field Running the latest prom-stack versions on legacy OpenShift clusters with no influence on the preinstalled CRDs results in errors such as this: failed to create typed patch object (..): .spec.automountServiceAccountToken: field not declared in schema This patch provides a workaround using this values.yaml: prometheus: prometheusSpec: automountServiceAccountToken: null Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
schnatterer
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
jkroepke
reviewed
Dec 12, 2024
charts/kube-prometheus-stack/templates/prometheus/prometheus.yaml
Outdated
Show resolved
Hide resolved
See prometheus-community#4976 Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
…harts into feature/downward-compat-prom-automount
Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
|
Seems like dashboards needs to be generated first. |
Signed-off-by: Johannes Schnatterer <johannes.schnatterer@cloudogu.com>
|
Thanks for fast-tracking my PR, @jkroepke |
nihussmann
added a commit
to cloudogu/gitops-playground
that referenced
this pull request
Jan 9, 2025
…eAccountToken null thanks to prometheus-community/helm-charts#5051
nihussmann
added a commit
to cloudogu/gitops-playground
that referenced
this pull request
Jan 15, 2025
…eAccountToken null thanks to prometheus-community/helm-charts#5051 feat: removing securityContext in openshift. Openshift will set it's own SCC constraints by this.
ThomasMichael1811
pushed a commit
to cloudogu/gitops-playground
that referenced
this pull request
Jan 15, 2025
…eAccountToken null thanks to prometheus-community/helm-charts#5051 (#256) feat: removing securityContext in openshift. Openshift will set it's own SCC constraints by this.
ThomasMichael1811
pushed a commit
to cloudogu/gitops-playground
that referenced
this pull request
Jan 15, 2025
…eAccountToken null thanks to prometheus-community/helm-charts#5051 (#256) feat: removing securityContext in openshift. Openshift will set it's own SCC constraints by this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Running the latest prom-stack versions on legacy OpenShift clusters with no influence on the preinstalled CRDs results in errors such as this:
This PR provides a workaround using this values.yaml:
Yes, this is no ideal solution, but that seems to be what the enterprise-world requires 😐️
Special notes for your reviewer
This is the same as #4906 only for the new field
prometheus.prometheusSpec.automountServiceAccountTokenthat was introduced to the Prometheus CRD in 34b499c and then added to the chart in ff10663, which leads to the incompatibility.@jkroepke Could I ask you again to review this?
Checklist
[prometheus-couchdb-exporter])