Add PROCESSES document #44
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,25 @@ | ||
| # See https://github.com/scottrigby/prometheus-helm-charts/issues/12 | ||
| # https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners | ||
| # https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax | ||
|
|
||
| # The repo admins team will be the default owners for everything in the repo. | ||
| # Unless a later match takes precedence, they will be requested for review when someone opens a pull request. | ||
| * @prometheus-community/helm-charts-admins | ||
|
|
||
| /charts/prometheus/ @gianrubio @zanhsieh @Xtigyro | ||
|
There was a problem hiding this comment. Nice catch on the preceding slash. As you said it's unlikely but possible for nested dirs in other charts to have one of these same names. Better to be explicit 👍 |
||
| /charts/prometheus-adapter/ @mattiasgees @steven-sheehy @hectorj2f | ||
| /charts/prometheus-blackbox-exporter/ @desaintmartin @gianrubio | ||
| /charts/prometheus-cloudwatch-exporter/ @gianrubio @torstenwalter @asherf | ||
| /charts/prometheus-consul-exporter @timm088 | ||
| /charts/prometheus-couchdb-exporter @gkarthiks | ||
| /charts/prometheus-mongodb-exporter @steven-sheehy | ||
| /charts/prometheus-mysql-exporter @juanchimienti @monotek | ||
| /charts/prometheus-nats-exporter @okgolove @caarlos0 | ||
| /charts/prometheus-node-exporter @gianrubio @vsliouniaev | ||
| /charts/prometheus-operator @vsliouniaev @bismarck @gianrubio | ||
| /charts/prometheus-postgres-exporter @gianrubio | ||
| /charts/prometheus-pushgateway @gianrubio @cstaud | ||
| /charts/prometheus-rabbitmq-exporter @juanchimienti | ||
| /charts/prometheus-redis-exporter @acondrat @zanhsieh | ||
|
|
||
| /charts/prometheus-snmp-exporter @miouge1 | ||
| /charts/prometheus-to-sd @acondrat | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Processes | ||
|
There was a problem hiding this comment. This processes file looks great 👌 |
||
|
|
||
| This document outlines processes and procedures for some common tasks in the charts repository. | ||
|
|
||
| ## Adding chart maintainers | ||
|
There was a problem hiding this comment. Perhaps it would help to also add sections for responsibilities of chart maintainers and repo admin roles? Per chat and your note about it as well here? #38 (comment) There was a problem hiding this comment. That's a good idea. I would love to split it up into smaller PRs as it's easier to review and get it merged. |
||
|
|
||
| Chart maintainers are defined within the chart itself. | ||
| So the procedure for adding maintainers is to add them there. | ||
| The pull request which does that should also update [CODEOWNERS](./github/CODEOWNERS) file to that the new maintainer is able to approve pull requests. | ||
| One of the existing chart maintainers needs to approve the PR in addition one of the repository admins needs to approve it. | ||
| They are then responsible for also granting the new maintainer write permissions to this repository. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯