Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Fix broken link in comment #141

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

Haavare
Copy link
Contributor

@Haavare Haavare commented Sep 24, 2020

Hi,
just a small change, the link should be like this:
https://prometheus.io/docs/alerting/latest/configuration/#tmpl_string

thanks

Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please raise chart version, & sign DCO.

@scottrigby scottrigby changed the title Fix broken link in comment [kube-prometheus-stack] Fix broken link in comment Sep 27, 2020
Signed-off-by: Håvar Eggereide <haavar.e@gmail.com>
@Haavare
Copy link
Contributor Author

Haavare commented Oct 1, 2020

@monotek
Now I think it is all done

gkarthiks
gkarthiks previously approved these changes Oct 2, 2020
Copy link
Contributor

@bismarck bismarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bismarck bismarck dismissed monotek’s stale review October 7, 2020 20:20

Changes made as requested.

@bismarck bismarck merged commit 7da9ee7 into prometheus-community:main Oct 7, 2020
@Haavare Haavare deleted the patch-1 branch November 27, 2020 12:56
stamzid pushed a commit to Unstructured-IO/prometheus-community-helm-charts that referenced this pull request Mar 3, 2023
…ity#141)

Signed-off-by: Håvar Eggereide <haavar.e@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants