Add current recursive clients metric #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Eves <michael.eves@autotrader.co.uk>
SuperQ
reviewed
May 12, 2020
Signed-off-by: Mike Eves <michael.eves@autotrader.co.uk>
|
LGTM |
Merged
SuperQ
added a commit
that referenced
this pull request
Jan 14, 2021
* [CHANGE] Replace legacy common/log with promlog #85 * [FEATURE] Add current recursive clients metric #74 * [FEATURE] Add zone serial numbers as metrics #91 * [FEATURE] Add TLS and basic authentication #94 * [BUGFIX] Use uint64 for counters in v3 xml. #70 * [BUGFIX] Fix Gauge type for large gauges #90 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
added a commit
that referenced
this pull request
Jan 14, 2021
* [CHANGE] Replace legacy common/log with promlog #85 * [FEATURE] Add current recursive clients metric #74 * [FEATURE] Add zone serial numbers as metrics #91 * [FEATURE] Add TLS and basic authentication #94 * [BUGFIX] Use uint64 for counters in v3 xml #70 * [BUGFIX] Fix Gauge type for large gauges #90 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
added a commit
that referenced
this pull request
Jan 14, 2021
* [CHANGE] Replace legacy common/log with promlog #85 * [FEATURE] Add current recursive clients metric #74 * [FEATURE] Add zone serial numbers as metrics #91 * [FEATURE] Add TLS and basic authentication #94 * [BUGFIX] Use uint64 for counters in v3 xml #70 * [BUGFIX] Fix Gauge type for large gauges #90 Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds recording of an additional metric,
recursive_clients_total.Bind limits the number of simultaneous recursive client looks. Reaching this limit will cause subsequent requests to fail, so recording/monitoring this metric feels sensible.