Add REFUSED label for metric bind_resolver_response_errors_total #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…response_errors_total Signed-off-by: Antonin Auroy <antonin.auroy@xmco.fr>
Merged
SuperQ
added a commit
that referenced
this pull request
Nov 10, 2022
* [FEATURE] Add REFUSED label for metric bind_resolver_response_errors_total #125 * [ENHANCEMENT] Decode resp.Body directly, without ioutil.ReadAll #84 * [ENHANCEMENT] Update exporter-toolkit to support new listen options #151 Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #124.
I've implemented separate datasets for v2 and v3 view statistics as I don't know if statistics about REFUSED queries are present in the v2 API.
Signed-off-by: Antonin Auroy antonin.auroy@xmco.fr