Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for timestamps in metrics #18

Closed
tomkerkhove opened this issue Oct 23, 2018 · 14 comments
Closed

Support for timestamps in metrics #18

tomkerkhove opened this issue Oct 23, 2018 · 14 comments
Assignees
@phnx47
Labels
enhancement

Comments

@tomkerkhove
Copy link

Are there plans to provide support for timestamp in metrics?

This is officially supported by Prometheus: https://prometheus.io/docs/instrumenting/exposition_formats/

metric_name [
"{" label_name "=" " label_value " { "," label_name "=" " label_value " } [ "," ] "}"
] value [ timestamp ]
@tomkerkhove tomkerkhove changed the title Support for Support for timestamps in metrics Oct 23, 2018
@tomkerkhove tomkerkhove mentioned this issue Oct 23, 2018
Closed
@phnx47 phnx47 self-assigned this Oct 23, 2018
@phnx47
Copy link
Member

phnx47 commented Oct 23, 2018

I need time for research

@tomkerkhove
Copy link
Author

Any update on this?

@tomkerkhove tomkerkhove mentioned this issue Dec 14, 2018
Closed
@phnx47
Copy link
Member

phnx47 commented Dec 18, 2018 via email •
edited
Loading

phnx47 added a commit that referenced this issue Jan 3, 2019
@phnx47
#18 Add Timestamp to Base classes
8922c8c
phnx47 added a commit that referenced this issue Jan 4, 2019
@phnx47
#18 Add includeTimestamp to constructors
b3c87bb
@phnx47
Copy link
Member

phnx47 commented Jan 4, 2019

In Progress...

phnx47 added a commit that referenced this issue Jan 4, 2019
@phnx47
#18 Add SetTimestamp
5479985
@tomkerkhove
Copy link
Author

I will come back in next year. Sorry for waiting.

No problem, take your time and thank you!

phnx47 added a commit that referenced this issue Jan 4, 2019
@phnx47
#18 Add Timestamp to TextFormatter
544a6e5
phnx47 added a commit that referenced this issue Jan 16, 2019
@phnx47
#18 Add includeTimestamp to CreateCounter
30022e0
phnx47 added a commit that referenced this issue Jan 21, 2019
@phnx47
#18 Add includeTimestamp to all metrics
8c00912
@phnx47
Copy link
Member

phnx47 commented Jan 21, 2019

@tomkerkhove Published to MyGet for test.

@tomkerkhove
Copy link
Author

It looks fine for me but do you also have plans to allow us to specify the stamp to use?

I'm not sure if the tracked value is correct, however, because in my sample it has 1548140899 which turns out to be 1/22/2019, 10:08:19 AM which is the local time and not GMT.

phnx47 added a commit that referenced this issue Jan 22, 2019
@phnx47
#18 Fix Timestamp
2d8b92e
@phnx47
Copy link
Member

phnx47 commented Jan 22, 2019

I don't have plan for use Timestamp right now. But I understand the benefits.

It is bug with GMT, I fixed it

@tomkerkhove
Copy link
Author

Thanks! Will create a seperate issue for passing timestamp when this one is closed

@tomkerkhove
Copy link
Author

Any reasons why you are not using DateTimeOffset.UnixEpoch rather than calculating it yourself?

@phnx47
Copy link
Member

phnx47 commented Jan 23, 2019

@tomkerkhove I did not know about this feature before

@phnx47
Copy link
Member

phnx47 commented Jan 24, 2019

DateTimeOffset.UnixEpoch isn't exists in netstandard

@phnx47
Copy link
Member

phnx47 commented Jan 24, 2019

Published 2.1.0

@tomkerkhove
Copy link
Author

Closing as this works and is pushed. Thanks!

@tomkerkhove tomkerkhove mentioned this issue Jan 24, 2019
Merged
@phnx47 phnx47 mentioned this issue Jan 25, 2019
Closed
@phnx47 phnx47 mentioned this issue Feb 14, 2019
Closed
@phnx47 phnx47 mentioned this issue Feb 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phnx47 phnx47

Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phnx47 @tomkerkhove