Transform function expression in expression macro instead of build macro #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At that point, all fields have been typed and that information can be
used, as with `Context.typeof` in `ETry` expression handling.
This fixes the `ETry` handling, that was partially broken. It used
`Context.typeof` before the field was typed and, therefore, didn't
recognize valid identifiers such as local variables or other fields.
The following example illustrates what failed with
`Unknown identifier : bar`
before and now works:
@:build(com.dongxiguo.continuation.Continuation.cpsByMeta("async"))
class Test {
@async static function foo(bar:String):Int
{
var x = try {
// sync stuff only, obviously
bar;
} catch (e:Dynamic) {
return 1;
}
// some async stuff
return 0;
}
static function main()
{
foo("hi", function (code) trace(code));
}
}
|
|
This fixes completion issues accidentally introduced with delaying expression transformation to when all fields have been typed. The position argument passed to `--display` must match the generated expression, and is usually inferred by tools from the source file. However, macro reification by default annotates the expression as positioned on the reification site, not on the original expression position, and thus makes them invisible or incorrectly placed for the completion engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At that point, all fields have been typed and that information can be used, as with
Context.typeofinETryexpression handling.This fixes the
ETryhandling, that was partially broken. It usedContext.typeofbefore the field was typed, and thus didn't recognize valid identifiers such as local variables or other fields. The following example illustrates what failed withUnknown identifier : barbefore and now works: