Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new treesitter group names #222

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

luisiacc
Copy link
Contributor

@luisiacc luisiacc commented Jan 3, 2023

Hi there, I've translated the old treesitter group names to the new ones so this theme can support new treesitter versions.

This is what it looks like:

image

image

@ful1e5
Copy link
Member

ful1e5 commented Jan 3, 2023

Thank you for your dedicated efforts and contributions!

@ful1e5 ful1e5 merged commit c55aab6 into projekt0n:main Jan 3, 2023
@ful1e5
Copy link
Member

ful1e5 commented Jan 3, 2023

Fixes #214

ful1e5 added a commit that referenced this pull request Jan 3, 2023
Added changelogs for pull request #222.
See `:h github-theme.changelog-03012023`
@ful1e5
Copy link
Member

ful1e5 commented Jan 3, 2023

I'm uncertain if this PR will resolve language-specific issues #220 and #215, but if it doesn't, I will fix them in the refactor. I am writing here to inform you all.

@karimdjemai
Copy link

#220 seems resolved now, thanks a lot!

@AlexXi19
Copy link

AlexXi19 commented Jan 3, 2023

Hi, I still have the same issue as #220 and also with a go project but I'm not seeing the changes reflected. I'm new to neovim and I'm using packer, and I've verified that the package is with the latest commit? Thanks for your work on this project!

Github Dark Default in VsCode
image
Dark Default in nvim
Screen Shot 2023-01-03 at 1 55 49 PM

@domvo
Copy link

domvo commented Jan 4, 2023

Thanks for the fix and the project in general, it did change things for the better, but I still have a vastly different result compared to what's expected.

Left: nvim, right: vscode

Screenshot 2023-01-04 at 10 19 40

Maybe it's a misconfiguration on my side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants